Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDMS-200 initial version of decision refactoring #27

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

craigedmunds
Copy link
Contributor

No description provided.

@@ -26,7 +27,9 @@ public class AuditEntry

public List<AuditDiffEntry> Diff { get; set; } = new();

public Dictionary<string, Dictionary<string, string>> Context { get; set; } = new();
// TODO - getting a serialisation error when using IAuditContext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its a BSON error, then if you put BsonKnownTypes on the interface, i think that fixes it (it auto adds a _t field with the type name so it knows the concrete type to deserialise back into)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute 'MongoDB.Bson.Serialization.Attributes.BsonKnownTypesAttribute' is not valid on this declaration type. It is valid on 'Class, Struct' declarations only.

So not valid on either an interface or property :(

@craigedmunds craigedmunds force-pushed the feature/cdms-200-decision-analytics branch from 1eb0c84 to 31a4b1f Compare December 23, 2024 16:30
@craigedmunds craigedmunds marked this pull request as ready for review December 23, 2024 16:31
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Btms.Business 65% 47%
Btms.Types.Gvms.Mapping 38% 26%
Btms.Metrics 82% 0%
Btms.Types.Gvms 67% 100%
Btms.Types.Alvs.Mapping 76% 0%
Btms.Types.Ipaffs.Mapping 73% 30%
TestDataGenerator 62% 48%
Btms.Azure 43% 75%
Btms.BlobService 31% 19%
Btms.Backend.Data 65% 61%
Btms.Consumers 75% 64%
Btms.Common 82% 25%
Btms.Model 89% 80%
Btms.SyncJob 73% 62%
Btms.SensitiveData 80% 83%
Btms.Types.Ipaffs 94% 56%
Btms.Types.Alvs.Mapping.V1.Tests 0% 0%
Btms.Types.Alvs 84% 67%
Btms.Emf 11% 6%
Btms.Backend 63% 49%
Btms.Analytics 59% 62%
Summary 70% (6646 / 9443) 48% (586 / 1218)

@craigedmunds craigedmunds merged commit a86a753 into main Dec 23, 2024
2 checks passed
@craigedmunds craigedmunds deleted the feature/cdms-200-decision-analytics branch December 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants